This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix a long standing bug for AMD64 with very large frames and using a scratch register. #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BruceForstall @CarolEidt @schellap |
| // cmp rax, -frameSize 6 | ||
| // jge loop 2 | ||
| // | ||
| // For AMD64 using RAX |
There was a problem hiding this comment.
You mean "For AMD64 NOT using RAX"
|
LGTM |
When having a really large frame the code for generating funclet prolog expects to have RAX being used as initReg. For AMD64 the RBP is being pushed and then used as scratch (and passed as initReg.) This was causing the assert to trigger. Added code to handle properly use of RBP on AMD64 and also modified the assert to properly allow RAX and RBP as initReg.
|
LGTM |
LLITCHEV
added a commit
that referenced
this pull request
Mar 18, 2015
Fix a long standing bug for AMD64 with very large frames and using a scratch register.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having a really large frame the code for generating funclet prolog
expects to have RAX being used as initReg. For AMD64 the RBP is being
pushed and then used as scratch (and passed as initReg.) This was causing
the assert to trigger.
Added code to handle properly use of RBP on AMD64 and also modified the
assert to properly allow RAX and RBP as initReg.