Update XML output for extensions #9416
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the sample code and text output to match the current compiler output.
|
@jcouv This changes matches what I'm seeing in the latest compiler. Can you verify? |
|
/cc @huangmin-ms |
jcouv
reviewed
May 30, 2025
| </member> | ||
| <member name="M:E.M``2(``0,``1)"> | ||
| <inheritdoc cref="M:E.<>E__0`1.M``1(``0)"/> | ||
| <member name="M:ClassLibrary6.E..AddValue(System.Int32)"> |
There was a problem hiding this comment.
This is the wrong expectation. The correct output is <member name="M:ClassLibrary6.E.<>E__0.AddValue(System.Int32)">.
The same comment applies elsewhere: the extension block should appear with its synthesized name (<>E__ followed by an index) and the synthesized name should be escaped (fix pending).
|
Converting to draft. I'll update after dotnet/roslyn#78735 gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the sample code and text output to match the current compiler output.