Skip to content

Remove examples that show insecure practices #10435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 26, 2024
Merged

Remove examples that show insecure practices #10435

merged 5 commits into from
Sep 26, 2024

Conversation

gewarren
Copy link
Contributor

Contributes to #10342.

(Hide whitespace changes.)

@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Sep 26, 2024
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
BillWagner
BillWagner approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @gewarren

I had one question, primarily for my knowledge, Go ahead and :shipit: when ready.

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit c6a5c00:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Web.Configuration/FormsAuthenticationUserCollection.xml ⚠️Warning View Details
includes/forms-auth-warning.md ✅Succeeded View
includes/ropc-warning.md ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData SqlCommand.ExecuteReader Example/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData SqlCommand.ExecuteReader2/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData SqlConnection.BeginTransaction Example/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData SqlConnection.BeginTransaction2 Example/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData SqlConnection.BeginTransaction3 Example/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData SqlDataReader.Read Example/CS/SqlDataReader.Read.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlConnectionStringBuilder.Remove/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlConnectionStringBuilder.Remove/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlConnectionStringBuilder/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlConnectionStringBuilder/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.AuthenticationSection/CS/authenticationsection.cs ✅Succeeded View
snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.AuthenticationSection/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.FormsAuthenticationConfiguration/CS/formsauthenticationconfiguration.cs ✅Succeeded View
snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.FormsAuthenticationConfiguration/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.FormsAuthenticationCredentials/CS/formsauthenticationcredentials.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.FormsAuthenticationUser/CS/formsauthenticationuser.cs ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData SqlCommand.ExecuteReader Example/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData SqlCommand.ExecuteReader2/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData SqlCommand.SqlCommand2 Example/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData SqlConnection.BeginTransaction Example/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData SqlConnection.BeginTransaction2 Example/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData SqlConnection.BeginTransaction3 Example/VB/Project.vbproj ✅Succeeded

This comment lists only the first 25 files in the pull request.

xml/System.Web.Configuration/FormsAuthenticationUserCollection.xml

  • Line 0, Column 0: [Warning: invalid-code] The code snippet "~/snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.FormsAuthenticationCredentials/CS/formsauthenticationcredentials.cs" could not be found.
  • Line 0, Column 0: [Warning: invalid-code] The code snippet "~/snippets/visualbasic/VS_Snippets_WebNet/System.Web.Configuration.FormsAuthenticationCredentials/VB/formsauthenticationcredentials.vb" could not be found.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren gewarren enabled auto-merge (squash) September 26, 2024 21:57
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 11a7940:

✅ Validation status: passed

File Status Preview URL Details
includes/forms-auth-warning.md ✅Succeeded View
includes/ropc-warning.md ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData SqlCommand.ExecuteReader Example/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData SqlCommand.ExecuteReader2/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData SqlConnection.BeginTransaction Example/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData SqlConnection.BeginTransaction2 Example/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData SqlConnection.BeginTransaction3 Example/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData SqlDataReader.Read Example/CS/SqlDataReader.Read.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlConnectionStringBuilder.Remove/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlConnectionStringBuilder.Remove/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlConnectionStringBuilder/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlConnectionStringBuilder/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.AuthenticationSection/CS/authenticationsection.cs ✅Succeeded View
snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.AuthenticationSection/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.FormsAuthenticationConfiguration/CS/formsauthenticationconfiguration.cs ✅Succeeded View
snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.FormsAuthenticationConfiguration/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.FormsAuthenticationCredentials/CS/formsauthenticationcredentials.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.FormsAuthenticationUser/CS/formsauthenticationuser.cs ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData SqlCommand.ExecuteReader Example/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData SqlCommand.ExecuteReader2/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData SqlCommand.SqlCommand2 Example/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData SqlConnection.BeginTransaction Example/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData SqlConnection.BeginTransaction2 Example/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData SqlConnection.BeginTransaction3 Example/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/DataWorks SqlConnectionStringBuilder.Remove/VB/Project.vbproj ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 29788eb into dotnet:main Sep 26, 2024
3 checks passed
Rick-Anderson
Rick-Anderson reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive improvement

@gewarren gewarren deleted the ropc-fixes branch September 27, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rick-Anderson Rick-Anderson Rick-Anderson left review comments

@BillWagner BillWagner BillWagner approved these changes

@David-Engel David-Engel Awaiting requested review from David-Engel David-Engel is a code owner

@JRahnama JRahnama Awaiting requested review from JRahnama

Assignees

@gewarren gewarren

Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gewarren @BillWagner @Rick-Anderson