Skip to content

Replaced dropped text on setting visual properties #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2019
Merged

Replaced dropped text on setting visual properties #1748

merged 2 commits into from
Feb 1, 2019

Conversation

rpetrusha
Copy link

Replaced dropped text on setting visual properties

Fixes #1746

@rpetrusha rpetrusha added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Jan 31, 2019
@rpetrusha rpetrusha self-assigned this Jan 31, 2019
mairaw
mairaw approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's going with all those warnings but love the changes you made moving that content into an include file. Left just a tiny comment for you to consider.

@rpetrusha rpetrusha merged commit b78a297 into dotnet:master Feb 1, 2019
@rpetrusha rpetrusha deleted the templatebinding branch February 22, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

Assignees

@rpetrusha rpetrusha

Labels
migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN
Projects
None yet
Milestone
February 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@rpetrusha @mairaw