Clarify that InternalsVisibleTo exposes private protected to a friend assembly #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior of the new in C# 7.2 is ambigious with regards to whether InternalVisibleTo exposes it to friend assemblies or not. It is good to explicitly state that private protected is treated as internal and not as private with regards to cross-assembly visiblity
BillWagner
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
Thanks for making this update @glebuk I've reviewed the change and I'll 
now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added small note that explain behavior of private protected access modifier with regards to InternalVisibleTo attribute. When reading the doc it is not clear that this attribute makes private protected available, as it only mentions internal.