Enable consuming public .NET SDK builds from the VMR using DarcLib #6379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbussell
force-pushed
the
update-deps-vmr
branch
2 times, most recently
from
e0e88b6 to
5403c66
Compare
lbussell
force-pushed
the
update-deps-vmr
branch
from
5403c66 to
2f79d58
Compare
lbussell
changed the title
mthalman
reviewed
Apr 21, 2025
| Asset {asset.Name} has {asset.Locations.Count} locations: | ||
| {allLocations} | ||
| """, | ||
| asset.Name, asset.Locations.Count, allLocations); |
There was a problem hiding this comment.
These extra arguments are unnecessary since you already referenced them in the string interpolation. This applies to some other usages throughout this PR too.
There was a problem hiding this comment.
It's a quirk of Microsoft.Extensions.Logging. It does its own string interpolation, and you get an IDE warning if you use the built-in string interpolation. This is so that the logger implementation can capture the actual values of the things you pass in for filtering and analysis later. And reduces the runtime overhead of performing the string interpolation if logging is turned off.
mthalman
approved these changes
Apr 21, 2025
This was referenced Apr 21, 2025
lbussell
added a commit
to lbussell/dotnet-docker
that referenced
this pull request
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft since it's based on #6378. It will be rebased once that PR is merged.
Adds a new command
from-channelwhich takes a channel and repo to get the latest build from. It should only work for the VMR for now. In the future maybe we'll allow other repos like monitor, yarp, aspire, etc..This iteration of the code simply gets the new .NET versions from BAR by reading a single build asset containing those versions. Then it sets up a call to the
specificversions command and executes it. So, we are still relying onSpecificCommandand all its code for resolving product version hashes. In the future, all versions and hashes should be read directly from the BAR build. But this is the MVP for consuming VMR builds.Todo: