Skip to content

Improvements to the M5 Stack Sample #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 1, 2025
Merged

Conversation

pgrawehr
Copy link
Contributor

@pgrawehr pgrawehr commented Apr 27, 2025

The SentenceCache now also "forgets" about messages that
are too old.

Plus a set of various bugfixes.

Microsoft Reviewers: Open in CodeFlow

@pgrawehr pgrawehr marked this pull request as draft May 8, 2025 14:44
pgrawehr added 2 commits May 19, 2025 21:48
Otherwise, the project can only build against previous package version in release mode.
@pgrawehr pgrawehr marked this pull request as ready for review May 22, 2025 15:19
[Option("nosleep", Default = false, HelpText = "Do not send the device to sleep when process terminates")]
public bool NoSleep { get; set; }

[Option("flipscreen", Default = false, HelpText = "Rotates the screen by 180 degrees")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this rotating or mirroring? name suggests mirror

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns it upside-down.

Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing comments

@pgrawehr pgrawehr merged commit 9021ade into dotnet:main Jun 1, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants