-
Notifications
You must be signed in to change notification settings - Fork 597
Improvements to the M5 Stack Sample #2392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The SentenceCache now forgets about object that are too old.
Otherwise, the project can only build against previous package version in release mode.
[Option("nosleep", Default = false, HelpText = "Do not send the device to sleep when process terminates")] | ||
public bool NoSleep { get; set; } | ||
|
||
[Option("flipscreen", Default = false, HelpText = "Rotates the screen by 180 degrees")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this rotating or mirroring? name suggests mirror
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns it upside-down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after addressing comments
Co-authored-by: Krzysztof Wicher <[email protected]>
The SentenceCache now also "forgets" about messages that
are too old.
Plus a set of various bugfixes.
Microsoft Reviewers: Open in CodeFlow