Skip to content

F# BikeSharing sample never ends training when running as F5 in Visual Studio #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CESARDELATORRE opened this issue Jan 24, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@CESARDELATORRE
Copy link
Contributor

The F# BikeSharingDemand sample has an issue (it also happens in C# for other samples if not using a workaround explained below).

Basically, in 0.9, the pipeline cache is not enabled by default (because of multiple reasons) and there's a related bug when you run the sample in VS with F5 (Debugging attached to process) where too many threads are created and the process never-ends...

The bug is explained in this issue I opened in the ML.NET repo:
dotnet/machinelearning#2099

Basically, the workaround is to explicitly enable the pipeline cache with this:

.AppendCacheCheckpoint(mlContext);

You might notice a lot of training perf improvement when using the cache, too, so you might want to add it to additional samples if it improves the training and test time. :)

However, this change has to be done directly into the pipeline. You don't have that method in the "ModelBuilder" helper class.

I would also recommend to step-out of the "ModelBuilder" helper class as we did in late November 2018 for the C# samples because these kind of code changes but mostly because we want developers to directly learn the ML.NET API. If using these helper classes, a developer might not clearly see how the ML.NET API is shaped.. This is specially important for the pipeline-chain API.

@CESARDELATORRE CESARDELATORRE added the bug Something isn't working label Jan 24, 2019
@mariuszwojcik
Copy link
Contributor

@CESARDELATORRE thanks for info, I will look into this in the next few days.

And regarding 'ModelBuilder' helper module - makes sense! Will move the code into relevant functions.

mariuszwojcik added a commit to mariuszwojcik/machinelearning-samples that referenced this issue Feb 4, 2019
CESARDELATORRE pushed a commit that referenced this issue Feb 5, 2019
…99 (#228)

* #202: migrate BikeSharingDemand F# sample to v0.9

* migrate Sentiment Analysis F# sample to v0.9

* #213:  append CacheCheckpoint in F# samples to mitigate ML.NET bug #2099
CESARDELATORRE pushed a commit that referenced this issue Feb 6, 2019
…231)

* #202: migrate BikeSharingDemand F# sample to v0.9

* migrate Sentiment Analysis F# sample to v0.9

* #213:  append CacheCheckpoint in F# samples to mitigate ML.NET bug #2099

* #FS230: move F# BikeSharingDemand example to use direct ML.NET API.
CESARDELATORRE pushed a commit that referenced this issue Feb 8, 2019
…API. (#238)

* #202: migrate BikeSharingDemand F# sample to v0.9

* migrate Sentiment Analysis F# sample to v0.9

* #213:  append CacheCheckpoint in F# samples to mitigate ML.NET bug #2099

* #FS230: move F# BikeSharingDemand example to use direct ML.NET API.

* #FS230: move F# MultiClassification_Iris sample to use direct ML.NET API.
@kevmal
Copy link
Contributor

kevmal commented Mar 8, 2019

I think this issues has been resolved

@prathyusha12345
Copy link
Contributor

Closing this issue.
Thanks :)

@CESARDELATORRE Adding for referrence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants