-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add F# samples #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add F# samples #36
Conversation
Would it be possible to add the F# samples (this PR) to the branch "dotnet/machinelearning-samples" instead of MASTER branch? - Until F# is supported in the public release of ML.NET. I'll add the Csharp changes about the folders first, to MASTER and to "dotnet/machinelearning-samples" branches, though. |
Never mind, I just saw your email. Let's keep the PR against MASTER. But we'll need to wait for the merge to happen. |
@asthana86 @CESARDELATORRE This change is now much smaller now #35 is in, if you'd like to start reading the F#. Main points to note are
Good intro guides to F# are at https://fsharpforfunandprofit.com/ |
@dsyme Pretty sure I am not the person you intended to tag 😄 |
@ankitbko - You're right, was after @asthana86 :) |
samples/nuget.config
Outdated
@@ -5,5 +5,6 @@ | |||
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" /> | |||
<!-- Use this if you want consume the daily builds of ML.NET --> | |||
<!-- <add key="Dailies" value="https://dotnet.myget.org/F/dotnet-core/api/v3/index.json" /> --> | |||
<add key="localPath" value="C:\GitHub\dsyme\machinelearning\bin/packages" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted. It is causing CI to fail.
Variation on #32 to add F# samples after moving C# samples to "csharp" directory
Things to do: