Skip to content

Logistic Regression doesn't work with training stats #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaeldekel opened this issue Oct 9, 2018 · 4 comments · Fixed by #1236
Closed

Logistic Regression doesn't work with training stats #1205

yaeldekel opened this issue Oct 9, 2018 · 4 comments · Fixed by #1236
Assignees
Labels
bug Something isn't working
Milestone

Comments

@yaeldekel
Copy link

Stats that are being computed at training time aren't passed to the predictor.

@yaeldekel yaeldekel self-assigned this Oct 9, 2018
@Zruty0
Copy link
Contributor

Zruty0 commented Oct 10, 2018

#1006 is related?

@montebhoover
Copy link
Contributor

Yes, this looks the same as #1006.

@montebhoover
Copy link
Contributor

montebhoover commented Oct 11, 2018

@yaeldekel , from the comment on #1006 below, it sounds like we are both not passing training-time stats to the predictor, and there are more stats for us to calculate. Does that ring true?

"If I do [pass _stats to the predictor], then predictor.Statistics.GetCoefficientStatistics still returns null. It appears that you calculate the inverted Hessian, but then do not use it to calculate standard errors (and pass these in the constructor of `LinearModelStatistics')"

@Ivanidzo4ka
Copy link
Contributor

what about #612 ?
I would assume you fix it because you working on one not-allowed-to-mention repository, and even if you bring stats, you wouldn't bring whole old version since this one doesn't have standard errors.

@Ivanidzo4ka Ivanidzo4ka added the bug Something isn't working label Oct 19, 2018
@shauheen shauheen added this to the 1018 milestone Oct 22, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
5 participants