Skip to content

Training Statistics for linear learners. #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sfilipi opened this issue Jul 31, 2018 · 2 comments
Closed

Training Statistics for linear learners. #612

sfilipi opened this issue Jul 31, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sfilipi
Copy link
Member

sfilipi commented Jul 31, 2018

When trying to split OLS as a separate learner, on PR #611, we noticed that LogisticRegression has a dependency on MKL to generate training stats.

Since we don't want the core ML.Net package to have dependencies on other large packages, i am removing the stats generation through PR #611 and should introduce a Utility, in the AdditionalLearners package, (or the package that has a reference to Mkl) and produce those stats post training.

@sfilipi sfilipi self-assigned this Jul 31, 2018
@sfilipi sfilipi added the enhancement New feature or request label Jul 31, 2018
@shauheen shauheen added this to the 0818 milestone Aug 6, 2018
@shauheen shauheen modified the milestones: 0818, 0918 Aug 31, 2018
@shauheen shauheen removed this from the 0918 milestone Sep 25, 2018
@montebhoover
Copy link
Contributor

This will fix #1006.

@sfilipi
Copy link
Member Author

sfilipi commented Oct 26, 2018

@GalOshri @TomFinley @shauheen I am thinking to add another LogisticRegression trainer in the HAL learner package, that computes the training stats wit SDV making use of MKL.

The ComputeTrainingStats method is called at the end of training from the base class.

The other alternative would be, as Tom suggested, to create an utility method that takes all the state necessary to re-compute the training stats. This would be limited to programmatic use, and to me feels less usable than introducing an alternative learner.

Open WIP #1392. we can discuss there as well.

@shauheen shauheen modified the milestones: 1018, 1118 Nov 7, 2018
@shauheen shauheen closed this as completed Dec 6, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants