No artifacts produced when CI builds time out

[artidoro]

This is related to #1473.

Our current CI builds hang quite often. #1473 suggests to retain the output files produced during tests and inspect them to help identify the problem. Thanks to #1527 we now produce artifacts. However, we only produce them when the builds fail, and not when they time out. It would be useful to produce the artifacts also when the builds time out as that is a significant part of the current build issues encountered.

Take https://dnceng.visualstudio.com/public/_build/results?buildId=40590&view=logs for example. You cannot access the artifacts because the build simply timed out.

Here instead, there was one build failure and one time out. You can only access artifacts for the build that failed. https://dnceng.visualstudio.com/public/_build/results?buildId=40591&view=logs

[artidoro]

Adding @montebhoover, @safern to this as you worked on publishing the test outputs. Is there an easy way to add a "timeout" condition?

[safern]

You could add a condition to be an or of failed or canceled -- https://docs.microsoft.com/en-us/azure/devops/pipelines/process/conditions?view=vsts&tabs=yaml#failed

Or even use the always variable, however that will run even when it didn't failed.

Also consider that you might need to specify a timeout after it was canceled so that the tasks have some time to actually run: https://docs.microsoft.com/en-us/azure/devops/pipelines/build/options?view=vsts&tabs=yaml#job-cancel-timeout