Publish test artifacts on timeout and not just failure #1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfilipi
approved these changes
Nov 7, 2018
|
@dotnet-bot rebuild this PR please. |
|
There is a syntax error in the yaml template that is why there is no steps shown in the build:
|
|
Yes I am still working on it! But thanks for already taking a look at it. |
artidoro
changed the title
|
Now it should be ready for review! |
safern
approved these changes
Nov 7, 2018
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1556.
In this PR I add a condition so that we post test artifacts not just in case of failures, but also in case of timeouts, by using
not(succeeded())condition.I also set the timeout limit for the running the tests to 40 min (this does not include the build time). Still working on the right syntax for the timeout setting.