Skip to content

KmeansOnnxConversionTest failing on NetCoreApp3.0 #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Anipik opened this issue Jan 9, 2019 · 6 comments
Closed

KmeansOnnxConversionTest failing on NetCoreApp3.0 #2087

Anipik opened this issue Jan 9, 2019 · 6 comments
Assignees
Labels
P3 Doc bugs, questions, minor issues, etc. test related to tests

Comments

@Anipik
Copy link
Contributor

Anipik commented Jan 9, 2019

KmeansOnnxConversionTest is failing on NetCoreApp3.0
This happened after we changed the version of netcoreapp sdk to 3.0 preview1
Associated PR #2082

This is not caused due to any change in cpumath library as it is even reproducable by using the software implementation of the functions.

2019-01-09T01:44:33.0500908Z [xUnit.net 00:01:21.86]     Microsoft.ML.Tests.OnnxConversionTest.KmeansOnnxConversionTest [FAIL]
2019-01-09T01:44:33.3587704Z Failed   Microsoft.ML.Tests.OnnxConversionTest.KmeansOnnxConversionTest
2019-01-09T01:44:33.3591191Z Error Message:
2019-01-09T01:44:33.3644424Z  Assert.Equal() Failure
2019-01-09T01:44:33.3644561Z Expected: 0 (rounded from 0)
2019-01-09T01:44:33.3648151Z Actual:   NaN (rounded from NaN)
2019-01-09T01:44:33.3648305Z Stack Trace:
2019-01-09T01:44:33.3648786Z    at Microsoft.ML.Tests.OnnxConversionTest.CompareSelectedR4VectorColumns(String leftColumnName, String rightColumnName, IDataView left, IDataView right, Int32 precision) in D:\a\1\s\test\Microsoft.ML.Tests\OnnxConversionTest.cs:line 500
2019-01-09T01:44:33.3648953Z    at Microsoft.ML.Tests.OnnxConversionTest.KmeansOnnxConversionTest() in D:\a\1\s\test\Microsoft.ML.Tests\OnnxConversionTest.cs:line 159
2019-01-09T01:44:33.3649371Z Standard Output Messages:
2019-01-09T01:44:33.3649668Z  Test KmeansOnnxConversionTest: aborted: passed

cc @eerhardt @danmosemsft @tannergooding

@eerhardt
Copy link
Member

eerhardt commented Jan 9, 2019

It would be helpful to list what is failing about the test. Are base lined numbers not comparing? Is an exception happening? etc.

@Anipik
Copy link
Contributor Author

Anipik commented Jan 9, 2019

It would be helpful to list what is failing about the test

I intended to add the reason but i just forget while creathing the issue :P i updated the issue
there is no exception happening and its not a baseline comparision.

@danmoseley
Copy link
Member

I'm guessing perhaps one of @tannergooding conformance changes.

@wschin wschin added the need info This issue needs more info before triage label May 21, 2019
@wschin
Copy link
Member

wschin commented May 21, 2019

Does this problem still exist? I saw that ML.NET passes all CI tests.

@Anipik
Copy link
Contributor Author

Anipik commented May 21, 2019

The test is disabled for .NET core 3

[LessThanNetCore30OrNotNetCoreFact("netcoreapp3.0 output differs from Baseline. Tracked by https://github.com/dotnet/machinelearning/issues/2087")]

@antoniovs1029 antoniovs1029 added P3 Doc bugs, questions, minor issues, etc. test related to tests and removed need info This issue needs more info before triage labels Jan 10, 2020
@frank-dong-ms-zz frank-dong-ms-zz self-assigned this Apr 15, 2020
@frank-dong-ms-zz
Copy link
Contributor

Test is passing after upgrade to dotnet core 3.1

@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 Doc bugs, questions, minor issues, etc. test related to tests
Projects
None yet
Development

No branches or pull requests

6 participants