Skip to content

Using the latest Numeric vector apis #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Using the latest Numeric vector apis #2082

merged 2 commits into from
Jan 9, 2019

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Jan 9, 2019

  • updates the dotnet sdk version 3.0 preview
  • modifies the cpumath apis to use new vector256 and vector128 apis
  • corrects the software implementation of MatMulTrans

Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


[MethodImplAttribute(MethodImplOptions.AggressiveInlining)]
internal static unsafe Vector128<float> Load1(float* src, int* idx)
=> Sse.SetScalarVector128(src[idx[0]]);
=> Vector128.CreateScalar(src[idx[0]]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: If the upper bits don't need to be zero, it is more efficient to do CreateScalarUnsafe

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Anipik Anipik merged commit bdc9a9e into dotnet:master Jan 9, 2019
@Anipik Anipik deleted the vectore branch January 9, 2019 18:04
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants