You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently ONNXML.cs is generated manually using protobuf definition. It is also included as part of code coverage which should not happen and PR #2290 will remove it. We need to make it such that it is clear that file is not authored by ML.NET team and is coming from an external source.
I don't agree that this file needs to be generated during the build. Using the same code generation tool and the same version of the protobuf definition, the same C# file will be generated. There is no reason to do that generation on every build.
Another reason to not take this approach is Source Link debugging. If someone was trying to debug into this code, it wouldn't be possible if we didn't have it checked into our source control.
We need to make it such that it is clear that file is not authored by ML.NET team and is coming from an external source.
This is usually done by the following header in the .cs file:
I agree with @eerhardt. The format that ML.NET requires this file to be in is different from the generated version. We can choose to wrap the generated code, but that would be a lot of needless abstraction.
Currently ONNXML.cs is generated manually using protobuf definition. It is also included as part of code coverage which should not happen and PR #2290 will remove it. We need to make it such that it is clear that file is not authored by ML.NET team and is coming from an external source.
CC: @wschin , @shauheen , @TomFinley
The text was updated successfully, but these errors were encountered: