Exclude files not authored by ML.NET from code coverage #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2290 +/- ##
==========================================
+ Coverage 69.82% 71.12% +1.29%
==========================================
Files 786 779 -7
Lines 144185 140208 -3977
Branches 16617 16019 -598
==========================================
- Hits 100684 99729 -955
+ Misses 38954 36043 -2911
+ Partials 4547 4436 -111
|
codemzs
changed the title
codemzs
changed the title
sfilipi
approved these changes
Jan 29, 2019
zeahmed
reviewed
Jan 29, 2019
zeahmed
approved these changes
Jan 29, 2019
eerhardt
reviewed
Jan 29, 2019
| @@ -43,6 +43,8 @@ | |||
| but they need to be migrated. Excluding these classes should have very minimal effect on code coverage. | |||
| --> | |||
| <Exclude>[*]Microsoft.ML.*Contracts*,[*]Microsoft.ML.Internal.Utilities*,[*]Microsoft.ML.Data.VBuffer*</Exclude> | |||
| <ExcludeByAttribute>Obsolete,ExcludeFromCodeCoverage</ExcludeByAttribute> | |||
| <ExcludeByFile>$(BaseOutputPath)..\src\Microsoft.ML.Onnx\OnnxMl.cs,$(BaseOutputPath)..\src\Microsoft.ML.TensorFlow\TensorFlow\Buffer.cs,$(BaseOutputPath)..\src\Microsoft.ML.TensorFlow\TensorFlow\Tensor.cs,$(BaseOutputPath)..\src\Microsoft.ML.TensorFlow\TensorFlow\Tensorflow.cs</ExcludeByFile> | |||
There was a problem hiding this comment.
Instead of $(BaseOutputPath)..\src\Microsoft.ML.Onnx\... you can just use $(SourceDir)\Microsoft.ML.Onnx\...
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't make sense to include ONNX ML autogenerated C# to protobuf file generator and Tensorflow sharp files as part of code coverage.