Skip to content

Remove the dead code inside the FastTree assembly #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sfilipi opened this issue Feb 7, 2019 · 2 comments
Closed

Remove the dead code inside the FastTree assembly #2468

sfilipi opened this issue Feb 7, 2019 · 2 comments
Labels
good first issue Good for newcomers nit Needs a really small fix up-for-grabs A good issue to fix if you are trying to contribute to the project

Comments

@sfilipi
Copy link
Member

sfilipi commented Feb 7, 2019

The code inside src/Microsoft.ML.FastTree/Application is not in use.

Delete the Folder.
@sfilipi sfilipi added good first issue Good for newcomers up-for-grabs A good issue to fix if you are trying to contribute to the project nit Needs a really small fix labels Feb 7, 2019
@sfilipi sfilipi mentioned this issue Feb 7, 2019
Merged
@mareklinka mareklinka mentioned this issue Feb 8, 2019
Merged
@codemzs
Copy link
Member

codemzs commented Feb 8, 2019

Have you confirmed this is not used by internal repo? If it is we should make sure we move these files there after they are removed from here.

@Ivanidzo4ka
Copy link
Contributor

They are used, but I don't see huge issues in restoring this files internally.
I'm closing issue, since files and catalog no longer part of this repository.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers nit Needs a really small fix up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codemzs @Ivanidzo4ka @sfilipi