Skip to content

The samples that are part of the Microsoft.ML.Samples project need to have a corresponding baseline test #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sfilipi opened this issue Mar 14, 2019 · 4 comments
Closed

The samples that are part of the Microsoft.ML.Samples project need to have a corresponding baseline test #2954

sfilipi opened this issue Mar 14, 2019 · 4 comments
Assignees
@codemzs
Labels
documentation Related to documentation of ML.NET P2 Priority of the issue for triage purpose: Needs to be fixed at some point. test related to tests

Comments

@sfilipi
Copy link
Member

sfilipi commented Mar 14, 2019

The samples currently have compile time checks, by being part of the solution, but not runtime validation.
Create a baseline test for each sample, to verify the output of their execution has not changed.
@sfilipi sfilipi self-assigned this Mar 14, 2019
@sfilipi sfilipi added test related to tests documentation Related to documentation of ML.NET labels Mar 14, 2019
@shmoradims
Copy link

At the very lease we should make sure they samples are runnable. Full blown baseline might be too costly. We already have those for unit tests.

@shmoradims shmoradims mentioned this issue Mar 21, 2019
Merged
@shmoradims shmoradims mentioned this issue Apr 3, 2019
Closed
@codemzs codemzs assigned codemzs and unassigned sfilipi Apr 3, 2019
@codemzs
Copy link
Member

codemzs commented Apr 3, 2019

@sfilipi As per our conversation at lunch, I'm assigning this to myself.

@sfilipi
Copy link
Member Author

sfilipi commented Apr 23, 2019

@codemzs i think this is complete? should we reference the PR and close it?

@shmoradims shmoradims added the P2 Priority of the issue for triage purpose: Needs to be fixed at some point. label May 21, 2019
@najeeb-kazmi
Copy link
Member

Closed in #3309. Created a stand alone app that will run all samples.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@codemzs codemzs

Labels
documentation Related to documentation of ML.NET P2 Priority of the issue for triage purpose: Needs to be fixed at some point. test related to tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@codemzs @najeeb-kazmi @shmoradims @sfilipi