Skip to content

Standalone app to run all samples to catch run time exceptions. #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 17, 2019
Merged

Standalone app to run all samples to catch run time exceptions. #3309

merged 9 commits into from
Apr 17, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented Apr 12, 2019

fixes #3308

@codecov
Copy link

codecov bot commented Apr 12, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@9ca5a5a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3309   +/-   ##
=========================================
  Coverage          ?   72.64%           
=========================================
  Files             ?      807           
  Lines             ?   145191           
  Branches          ?    16223           
=========================================
  Hits              ?   105478           
  Misses            ?    35295           
  Partials          ?     4418
Flag Coverage Δ
#Debug 72.64% <ø> (?)
#production 68.17% <ø> (?)
#test 88.97% <ø> (?)

@codemzs codemzs force-pushed the samplesdrivertest branch from 783e860 to d6edf80 Compare April 12, 2019 22:33
@codemzs codemzs requested review from shmoradims, TomFinley, shauheen and Ivanidzo4ka and removed request for shauheen April 12, 2019 23:23
shmoradims
shmoradims approved these changes Apr 15, 2019
View reviewed changes
Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs requested review from eerhardt and shauheen April 16, 2019 02:09
@codemzs codemzs merged commit 66c5ff9 into dotnet:master Apr 17, 2019
@najeeb-kazmi najeeb-kazmi mentioned this pull request Feb 5, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wschin wschin wschin approved these changes

@shmoradims shmoradims shmoradims approved these changes

@artidoro artidoro Awaiting requested review from artidoro

@sfilipi sfilipi Awaiting requested review from sfilipi

@TomFinley TomFinley Awaiting requested review from TomFinley

@Ivanidzo4ka Ivanidzo4ka Awaiting requested review from Ivanidzo4ka

@eerhardt eerhardt Awaiting requested review from eerhardt

@shauheen shauheen Awaiting requested review from shauheen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standalone app to run all samples to catch run time exceptions
7 participants
@codemzs @Ivanidzo4ka @shauheen @wschin @eerhardt @TomFinley @shmoradims