Conversion of ordinary least square linear regression (OlsLinearRegression) to estimator #1002
Conversation
| /// <summary> | ||
| /// Initializes a new instance of <see cref="OlsLinearRegressionTrainer"/> | ||
| /// </summary> | ||
| /// <param name="env">The private instance of <see cref="IHostEnvironment"/>.</param> |
There was a problem hiding this comment.
private [](start = 34, length = 7)
not 'private'. Just say: "The environment to use" #Resolved
| /// <param name="env">The private instance of <see cref="IHostEnvironment"/>.</param> | ||
| /// <param name="labelColumn">The name of the label column.</param> | ||
| /// <param name="featureColumn">The name of the feature column.</param> | ||
| /// <param name="weightColumn">The name for the column containing the initial weight.</param> |
There was a problem hiding this comment.
column containing the initial weight [](start = 56, length = 36)
example weight column #Resolved
| { | ||
| var args = new Arguments(); | ||
|
|
||
| //apply the advanced args, if the user supplied any |
There was a problem hiding this comment.
//apply the advanced args, if the user supplied any [](start = 12, length = 51)
// Comments need to be 1 space away from the comment symbol, begin with a capital letter and end with a period. #Resolved
| @@ -34,7 +33,7 @@ | |||
| namespace Microsoft.ML.Runtime.HalLearners | |||
There was a problem hiding this comment.
Microsoft.ML.Runtime.HalLearners [](start = 10, length = 32)
I'm surprised Pete didn't comment about namespace, especially what it's still "Runtime". But I guess we didn't start to change namespaces for learners yet.
artidoro
changed the title
ghost
locked as resolved and limited conversation to collaborators
Ongoing work on converting the trainers to estimators. This PR converts the ordinary least squares linear regression (OlsLinearRegression).