LightGbm pigstensions #1020
LightGbm pigstensions #1020
Conversation
sfilipi
requested review from
Ivanidzo4ka,
TomFinley,
artidoro,
zeahmed and
Zruty0
| /// Check that the label, feature, weights is not supplied in the args of the constructor. | ||
| /// Those parameters should be internal if they are not used from the maml help code path. | ||
| /// </summary> | ||
| public static void CheckArgsDefaultColNames(IHost env, string defaultColName, string argValue) |
There was a problem hiding this comment.
IHost env [](start = 52, length = 9)
IExceptionContext please. #Resolved
| public static void CheckArgsDefaultColNames(IHost env, string defaultColName, string argValue) | ||
| { | ||
| if (argValue != defaultColName) | ||
| throw env.Except($"Don't supply a value for the {defaultColName} column in the arguments, as it will be ignored. Specify them in the loader, or constructor instead instead."); |
There was a problem hiding this comment.
instead instead [](start = 172, length = 15)
duplicate duplicate #Resolved
| @@ -382,6 +382,16 @@ public static SchemaShape.Column MakeR4ScalarWeightColumn(string weightColumn) | |||
| return null; | |||
| return new SchemaShape.Column(weightColumn, SchemaShape.Column.VectorKind.Scalar, NumberType.R4, false); | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Check that the label, feature, weights is not supplied in the args of the constructor. | |||
There was a problem hiding this comment.
args [](start = 74, length = 4)
Maybe ought to write out arguments. #Resolved
|
|
||
| /// <summary> | ||
| /// Check that the label, feature, weights is not supplied in the args of the constructor. | ||
| /// Those parameters should be internal if they are not used from the maml help code path. |
There was a problem hiding this comment.
maml help code path [](start = 78, length = 19)
Given the focus we now have I'm a little wary of having language specific to the command line in any new code, that is not somehow directly related to the command line, without plenty of explanatory text. Someone unaware of this software's roots as a tool rather than a library will have absolutely no idea what this means. #Resolved
| return rec.Output; | ||
| } | ||
|
|
||
| private static void CheckUserValues<TVal, TArgs, TPred>(Scalar<TVal> label, Vector<float> features, Scalar<float> weights, |
There was a problem hiding this comment.
we are just checking the presence of stuff, right? We could make label a 'PipelineColumn', and the delegates to be just 'Delegate', and this method will not need to be generic #Resolved
| { | ||
| public static class LightGbmStatics | ||
| { | ||
| public static Scalar<float> LightGbm(this RegressionContext.RegressionTrainers ctx, |
There was a problem hiding this comment.
copy the summary comment here #Resolved
| /// <param name="weightColumn">The name for the column containing the initial weight.</param> | ||
| /// <param name="advancedSettings">A delegate to apply all the advanced arguments to the algorithm.</param> | ||
| /// <param name="learningRate"></param> |
There was a problem hiding this comment.
add docs on empty parameters #Resolved
|
close/reopen to trigger a rebuild. |
|
close - reopen to trigger rebuild. |
|
close/reopen to trigger rebuild |
ghost
locked as resolved and limited conversation to collaborators
Ongoing work to address #754
Those are the LightGbm binary and regression extension methods.