Merge ModuleCatalog into ComponentCatalog. #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
requested review from
codemzs,
Ivanidzo4ka,
TomFinley,
yaeldekel and
Zruty0
TomFinley
reviewed
Sep 25, 2018
| @@ -290,8 +290,6 @@ public sealed class CmdParser | |||
| private const int SpaceBeforeParam = 2; | |||
| private readonly ErrorReporter _reporter; | |||
| private readonly IHost _host; | |||
| // REVIEW: _catalog should be part of environment and can be get through _host. | |||
There was a problem hiding this comment.
REVIEW: _catalog should be part of environment and can be get through _host. [](start = 11, length = 76)
How about that. :)
TomFinley
reviewed
Sep 25, 2018
| public static void Initialize() | ||
| { | ||
| ImageAnalytics.Initialize(); | ||
| } |
There was a problem hiding this comment.
What is the new alternative to this, for the sake of the legacy API? @yaeldekel
There was a problem hiding this comment.
We only have 2 of these empty Initialize() methods, so it wasn't really a holistic plan.
If someone is using the "new API" this isn't necessary at all.
If someone is using the legacy API, and needs to do this, they can follow the same approach outlined in the following issues:
- Hosting a pre-trained ML Model in Azure Functions #569 (comment)
- LoadTransform and LinearClassificationTrainer doesnot work in AzureFunctions #559
Basically, they can just get the typeof some type in that assembly to ensure it is loaded up front.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the ComponentCatalog refactoring work for
v0.6. It merges theModuleCatalogandComponentCatalogtypes into a single type.Follow up for #208.