-
Notifications
You must be signed in to change notification settings - Fork 1.9k
WIP: adding a nuget to package the datasets. #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@eerhardt @Ivanidzo4ka where can i find more info about the nupkgproj syntax? |
|
||
<ItemGroup> | ||
<Content Include="..\common\CommonPackage.props" Pack="true" PackagePath="build\netstandard2.0\$(MSBuildProjectName).props" /> | ||
<Content Include="..\..\test\data\syntheticRegressionTrain.txt" Pack="true" BuildAction="Content" target=".\content\regression\" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[](start = 0, length = 1)
SHOCK
<ItemGroup> | ||
<Content Include="..\common\CommonPackage.props" Pack="true" PackagePath="build\netstandard2.0\$(MSBuildProjectName).props" /> | ||
<Content Include="..\..\test\data\syntheticRegressionTrain.txt" Pack="true" BuildAction="Content" target=".\content\regression\" /> | ||
<Content Include="..\..\test\data\syntheticRegressionTest.txt" Pack="true" BuildAction="Content" target=".\content\regression\" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[](start = 0, length = 1)
AND HORROR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go on vacation :) #Closed
in nuspec world I use targets file (to force certain actions) and I put files into specific folder https://docs.microsoft.com/en-us/nuget/reference/nuspec#including-content-files In reply to: 427498975 [](ancestors = 427498975) |
|
||
<PropertyGroup> | ||
<TargetFramework>netstandard2.0</TargetFramework> | ||
<PackageDescription>ML.NET additional learners making use of hardware acceleration. They use Intel Mkl.</PackageDescription> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is out of date.
@@ -0,0 +1,14 @@ | |||
<Project Sdk="Microsoft.NET.Sdk" DefaultTargets="Pack"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd probably want to use a different nuget package name than Microsoft.ML.Datasets
. That seems like it could be a useful package name in the future that we may not want to take here. Maybe adding Test
or Sample
or some other such word would help users realize that this NuGet package isn't for typical consumption.
I would use |
@mairaw @JRAlexander - do we have other instances of where MSDN/docs.microsoft.com examples require you to install a NuGet package? I'm not sure I've seen this before. I'm wondering if we can't just have a simple loop that creates the data into a |
We won't package the datasets in a nuget, we will point users to downloading them from github, in the samples. |
The samples that appear in our documentation should have code that the user can copy/pate and execute.
For that purpose packaging the datasets in a NuGet whose namespace we can reference from the samples.
Addresses #1137