Fix zero based key input from C# classes for matrix factorization #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschin
changed the title
TomFinley
reviewed
Nov 3, 2018
TomFinley
reviewed
Nov 3, 2018
TomFinley
reviewed
Nov 3, 2018
TomFinley
reviewed
Nov 3, 2018
TomFinley
approved these changes
Nov 5, 2018
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the getter in IDataView created from C# classes doesn't handle key properly, matrix factorization fails whenever there is a zero-based key input. This PR fixes this issue by modifying getter upon peek, which doesn't care key type at all. The major fix occurs in
src/Microsoft.ML.Api/DataViewConstructionUtils.cs.In addition, a test based on matrix factorization is made for preventing such an error from happening again in
test/Microsoft.ML.Tests/TrainerEstimators/MatrixFactorizationTests.cs.In addition, matrix factorization also got polished. We clean up unnecessary fields and make its comments better.
Fix #1442.