Skip to content

adding more logging to failures. #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2018
Merged

adding more logging to failures. #1555

merged 2 commits into from
Nov 7, 2018

Conversation

sfilipi
Copy link
Member

@sfilipi sfilipi commented Nov 6, 2018

Fixes #1477 by adding more logging around the failure on the baselines number comparison.

Logging on failures looks like this now:

Values to compare are 0.49224 and 0.49223705031518167
	 AllowedVariance: 1E-07
	 delta: 2.9E-06
	 delta2: 2.9E-06

*** Failure: Output and baseline mismatch at line 3: 'FieldAwareFactorizationMachine\FieldAwareFactorizationMachine-CV-breast-cancer.txt
```'

@sfilipi sfilipi added the test related to tests label Nov 6, 2018
@sfilipi sfilipi self-assigned this Nov 6, 2018
TomFinley
TomFinley approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed seems much better, thank you @sfilipi !

@sfilipi
Copy link
Member Author

sfilipi commented Nov 6, 2018

I'll trigger a few rebuilds before merging it, see if we can get any insights.

artidoro
artidoro approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@artidoro artidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better than what we had!

@TomFinley
Copy link
Contributor

image

I just really appreciate the irony here. 😄

@sfilipi sfilipi merged commit d8402cd into dotnet:master Nov 7, 2018
@sfilipi sfilipi deleted the testLogs branch December 11, 2018 20:54
@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shauheen shauheen shauheen approved these changes

@TomFinley TomFinley TomFinley approved these changes

@artidoro artidoro artidoro approved these changes

@Ivanidzo4ka Ivanidzo4ka Awaiting requested review from Ivanidzo4ka

@montebhoover montebhoover Awaiting requested review from montebhoover

Assignees

@sfilipi sfilipi

Labels
test related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfilipi @TomFinley @shauheen @artidoro