Skip to content

Add test coverage for VBuffer #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 3, 2018
Merged

Add test coverage for VBuffer #1804

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
538fe7d
Add ScaleBy test
yaeldMS Nov 30, 2018
1b851c6
Add VBuffer unit tests, and fix a couple of bugs
yaeldMS Dec 1, 2018
eb3023b
Fix test tolerance
yaeldMS Dec 2, 2018
515db75
Address PR comments and fix unit test tolerance
yaeldMS Dec 3, 2018
96dd8f9
Fix AlignedArray bug
yaeldMS Dec 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.ML.Core/Utilities/MathUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ public static Float GetMedianInPlace(Float[] src, int count)
return (src[iv - 1] + src[iv]) / 2;
}

public static Double CosineSimilarity(Float[] a, Float[] b, int aIdx, int bIdx, int len)
public static Double CosineSimilarity(ReadOnlySpan<Float> a, ReadOnlySpan<Float> b, int aIdx, int bIdx, int len)
{
const Double epsilon = 1e-12f;
Contracts.Assert(len > 0);
Expand Down
8 changes: 8 additions & 0 deletions src/Microsoft.ML.Core/Utilities/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,14 @@ public static bool AreEqual(Double[] arr1, Double[] arr2)
return true;
}

public static void Shuffle<T>(Random rand, Span<T> rgv)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rgv [](start = 59, length = 3)

just curios, what it stands for?
random general values?

{
Contracts.AssertValue(rand);

for (int iv = 0; iv < rgv.Length; iv++)
Swap(ref rgv[iv], ref rgv[iv + rand.Next(rgv.Length - iv)]);
}

public static bool AreEqual(int[] arr1, int[] arr2)
{
if (arr1 == arr2)
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.Core/Utilities/VBufferUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1322,7 +1322,7 @@ public static void ApplyInto<TSrc1, TSrc2, TDst>(in VBuffer<TSrc1> a, in VBuffer
// REVIEW: Worth optimizing the newCount == a.Length case?
// Probably not...

editor = VBufferEditor.Create(ref dst, a.Length, newCount);
editor = VBufferEditor.Create(ref dst, a.Length, newCount, requireIndicesOnDense: true);
Span<int> indices = editor.Indices;

if (newCount == bValues.Length)
Expand Down
10 changes: 6 additions & 4 deletions src/Microsoft.ML.CpuMath/AlignedArray.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,21 +110,23 @@ public Float this[int index]
}
}

public void CopyTo(Float[] dst, int index, int count)
public void CopyTo(Span<Float> dst, int index, int count)
{
Contracts.Assert(0 <= count && count <= _size);
Contracts.Assert(dst != null);
Contracts.Assert(0 <= index && index <= dst.Length - count);
Array.Copy(Items, _base, dst, index, count);
for (int i = 0; i < count; i++)
Copy link
Member

@eerhardt eerhardt Dec 3, 2018 •
edited by yaeldekel
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I think this code is going away with #1657)

You don't need to copy element by element. Instead you can say Items.AsSpan(_base + i, count).CopyTo(dst); #Resolved

dst[index + i] = Items[_base + i];
}

public void CopyTo(int start, Float[] dst, int index, int count)
public void CopyTo(int start, Span<Float> dst, int index, int count)
{
Contracts.Assert(0 <= count);
Contracts.Assert(0 <= start && start <= _size - count);
Contracts.Assert(dst != null);
Contracts.Assert(0 <= index && index <= dst.Length - count);
Array.Copy(Items, start + _base, dst, index, count);
for (int i = 0; i < count; i++)
dst[index + i] = Items[start + _base + i];
}

public void CopyFrom(ReadOnlySpan<Float> src)
Expand Down
36 changes: 19 additions & 17 deletions src/Microsoft.ML.Data/Depricated/Vector/GenericSpanSortHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,49 +41,52 @@ internal static int FloorLog2PlusOne(int n)
}
}

internal partial class GenericSpanSortHelper<TKey, TValue>
internal partial class GenericSpanSortHelper<TKey>
where TKey : IComparable<TKey>
{
public static void Sort(Span<TKey> keys, Span<TValue> values, int index, int length)
public static void Sort<TValue>(Span<TKey> keys, Span<TValue> values, int index, int length)
{
Contracts.Assert(keys != null, "Check the arguments in the caller!");
Contracts.Assert(index >= 0 && length >= 0 && (keys.Length - index >= length), "Check the arguments in the caller!");

IntrospectiveSort(keys, values, index, length);
}

private static void SwapIfGreaterWithItems(Span<TKey> keys, Span<TValue> values, int a, int b)
public static void Sort(Span<TKey> keys, int index, int length)
{
Sort(keys, keys, index, length);
}

private static void SwapIfGreaterWithItems<TValue>(Span<TKey> keys, Span<TValue> values, int a, int b)
{
if (a != b)
{
if (keys[a] != null && keys[a].CompareTo(keys[b]) > 0)
{
TKey key = keys[a];
keys[a] = keys[b];
keys[b] = key;

TValue value = values[a];
keys[a] = keys[b];
values[a] = values[b];
keys[b] = key;
values[b] = value;
}
}
}

private static void Swap(Span<TKey> keys, Span<TValue> values, int i, int j)
private static void Swap<TValue>(Span<TKey> keys, Span<TValue> values, int i, int j)
{
if (i != j)
{
TKey k = keys[i];
keys[i] = keys[j];
keys[j] = k;

TValue v = values[i];
keys[i] = keys[j];
values[i] = values[j];
keys[j] = k;
values[j] = v;
}
}

internal static void IntrospectiveSort(Span<TKey> keys, Span<TValue> values, int left, int length)
internal static void IntrospectiveSort<TValue>(Span<TKey> keys, Span<TValue> values, int left, int length)
{
Contracts.Assert(keys != null);
Contracts.Assert(values != null);
Expand All @@ -99,7 +102,7 @@ internal static void IntrospectiveSort(Span<TKey> keys, Span<TValue> values, int
IntroSort(keys, values, left, length + left - 1, 2 * IntrospectiveSortUtilities.FloorLog2PlusOne(length));
}

private static void IntroSort(Span<TKey> keys, Span<TValue> values, int lo, int hi, int depthLimit)
private static void IntroSort<TValue>(Span<TKey> keys, Span<TValue> values, int lo, int hi, int depthLimit)
{
Contracts.Assert(keys != null);
Contracts.Assert(values != null);
Expand Down Expand Up @@ -146,7 +149,7 @@ private static void IntroSort(Span<TKey> keys, Span<TValue> values, int lo, int
}
}

private static int PickPivotAndPartition(Span<TKey> keys, Span<TValue> values, int lo, int hi)
private static int PickPivotAndPartition<TValue>(Span<TKey> keys, Span<TValue> values, int lo, int hi)
{
Contracts.Assert(keys != null);
Contracts.Assert(values != null);
Expand Down Expand Up @@ -191,7 +194,7 @@ private static int PickPivotAndPartition(Span<TKey> keys, Span<TValue> values, i
return left;
}

private static void Heapsort(Span<TKey> keys, Span<TValue> values, int lo, int hi)
private static void Heapsort<TValue>(Span<TKey> keys, Span<TValue> values, int lo, int hi)
{
Contracts.Assert(keys != null);
Contracts.Assert(values != null);
Expand All @@ -211,7 +214,7 @@ private static void Heapsort(Span<TKey> keys, Span<TValue> values, int lo, int h
}
}

private static void DownHeap(Span<TKey> keys, Span<TValue> values, int i, int n, int lo)
private static void DownHeap<TValue>(Span<TKey> keys, Span<TValue> values, int i, int n, int lo)
{
Contracts.Assert(keys != null);
Contracts.Assert(lo >= 0);
Expand All @@ -237,7 +240,7 @@ private static void DownHeap(Span<TKey> keys, Span<TValue> values, int i, int n,
values[lo + i - 1] = dValue;
}

private static void InsertionSort(Span<TKey> keys, Span<TValue> values, int lo, int hi)
private static void InsertionSort<TValue>(Span<TKey> keys, Span<TValue> values, int lo, int hi)
{
Contracts.Assert(keys != null);
Contracts.Assert(values != null);
Expand Down Expand Up @@ -265,5 +268,4 @@ private static void InsertionSort(Span<TKey> keys, Span<TValue> values, int lo,
}
}
}

}
3 changes: 2 additions & 1 deletion src/Microsoft.ML.Data/Depricated/Vector/VBufferMathUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,8 @@ public static void AddMultWithOffset(in VBuffer<Float> src, Float c, ref VBuffer
editor = VBufferEditor.Create(ref dst,
dst.Length,
dstValues.Length + gapCount,
keepOldOnResize: true);
keepOldOnResize: true,
requireIndicesOnDense: true);
var indices = editor.Indices;
values = editor.Values;
if (gapCount > 0)
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.Data/Depricated/Vector/VectorUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public static void SparsifyNormalize(ref VBuffer<Float> a, int top, int bottom,
}

if (!aEditor.Indices.IsEmpty)
GenericSpanSortHelper<int, float>.Sort(aEditor.Indices, aEditor.Values, 0, newCount);
GenericSpanSortHelper<int>.Sort(aEditor.Indices, aEditor.Values, 0, newCount);
a = aEditor.Commit();
}

Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ML.Data/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

[assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.TestFramework" + PublicKey.TestValue)]
[assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.Tests" + PublicKey.TestValue)]
[assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.Core.Tests" + PublicKey.TestValue)]
[assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.InferenceTesting" + PublicKey.TestValue)]
[assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.OnnxTransformTest" + PublicKey.TestValue)]

Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.Data/Scorers/FeatureContributionCalculationTransform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ private ValueGetter<ReadOnlyMemory<char>> GetTextValueGetter<TSrc>(IRow input, i
contributions.GetValues().CopyTo(values);
var count = values.Length;
var sb = new StringBuilder();
GenericSpanSortHelper<int, float>.Sort(indices, values, 0, count);
GenericSpanSortHelper<int>.Sort(indices, values, 0, count);
for (var i = 0; i < count; i++)
{
var val = values[i];
Expand Down
13 changes: 13 additions & 0 deletions src/Microsoft.ML.FastTree/Utils/LinqExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,19 @@ public static int ArgMax<T>(this T[] arr) where T : IComparable<T>
return argMax;
}

public static int ArgMax<T>(this ReadOnlySpan<T> span) where T : IComparable<T>
Copy link
Member

@eerhardt eerhardt Dec 3, 2018 •
edited by yaeldekel
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to remove the method above this, since arrays are implicitly convertible to ReadOnlySpan. #Resolved

{
if (span.Length == 0)
return -1;
int argMax = 0;
for (int i = 1; i < span.Length; i++)
{
if (span[i].CompareTo(span[argMax]) > 0)
argMax = i;
}
return argMax;
}

public static int ArgMin<T>(this T[] arr, int prefix) where T : IComparable<T>
{
int length = arr.Length < prefix ? arr.Length : prefix;
Expand Down
Loading