Remove IRowCursorConsolidator. #1938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomFinley
requested review from
codemzs,
Ivanidzo4ka,
eerhardt,
yaeldekel,
sfilipi and
glebuk
singlis
reviewed
Dec 20, 2018
singlis
reviewed
Dec 20, 2018
singlis
reviewed
Dec 20, 2018
singlis
reviewed
Dec 20, 2018
| const int toConsumeBound = 4; | ||
| var toConsume = new BlockingCollection<Batch>(toConsumeBound); | ||
| var batchColumnPool = new MadeObjectPool<BatchColumn[]>(() => new BatchColumn[outPipes.Length]); | ||
| Thread[] workers = new Thread[inputs.Length]; |
There was a problem hiding this comment.
So threads are used here, can the cursor set be large? Like in the hundreds for example? If so, would tasks be a better alternative?
|
Looks good to me - I didnt quite follow the "Scott document review". |
singlis
approved these changes
Dec 20, 2018
sfilipi
reviewed
Dec 20, 2018
|
|
||
| if (inputs.Length == 1) | ||
| curs = inputs[0]; | ||
| else | ||
| curs = consolidator.CreateCursor(host, inputs); | ||
| curs = DataViewUtils.ConsolidateGeneric(host, inputs, 64); |
There was a problem hiding this comment.
64 [](start = 70, length = 2)
maybe have a comment for why 64.
TomFinley
force-pushed
the
consolidator
branch
from
f031f43 to
36c5b98
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1867.