Skip to content

WIP [Please don't review] : Arguments, Options #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

WIP [Please don't review] : Arguments, Options #2000

wants to merge 4 commits into from

Conversation

abgoswam
Copy link
Member

@abgoswam abgoswam commented Jan 2, 2019 •
edited
Loading

TBD. Please do not review

  1. Rename Arguments to Options
  2. Pass Options object instead of Action delegate
  3. Provide distinct constructors/extension methods.

For #1798

@justinormont
Copy link
Contributor

justinormont commented Jan 2, 2019 •
edited by abgoswam
Loading

Can you reference an issue?
#Resolved

@abgoswam
Copy link
Member Author

abgoswam commented Jan 2, 2019

Its not ready for review yet.

I am only using it to verify if the builds work fine

In reply to: 451011546 [](ancestors = 451011546)

@abgoswam abgoswam changed the title WIP : Arguments, Options WIP [Please don't review] : Arguments, Options Jan 2, 2019
@abgoswam abgoswam closed this Jan 3, 2019
@abgoswam abgoswam deleted the abgoswam/arguments branch January 13, 2019 18:11
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abgoswam @justinormont