Make CompositeSchema not an ISchema #2001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove ISchema interface 2. Rename CompositeSchema to ZipBinding
Ivanidzo4ka
reviewed
Jan 3, 2019
| @@ -106,7 +106,7 @@ public RowCursor[] GetRowCursorSet(Func<int, bool> predicate, int n, Random rand | |||
| private sealed class Cursor : RootCursorBase | |||
| { | |||
| private readonly RowCursor[] _cursors; | |||
| private readonly CompositeSchema _compositeSchema; | |||
| private readonly ZipBinding _compositeSchema; | |||
There was a problem hiding this comment.
_compositeSchema [](start = 40, length = 16)
can you change name of variable?
Ivanidzo4ka
reviewed
Jan 3, 2019
| @@ -13,16 +13,16 @@ namespace Microsoft.ML.Data | |||
| /// A convenience class for concatenating several schemas together. | |||
| /// This would be necessary when combining IDataViews through any type of combining operation, for example, zip. | |||
| /// </summary> | |||
| internal sealed class CompositeSchema : ISchema | |||
| internal sealed class ZipBinding | |||
There was a problem hiding this comment.
Shall we rename file as well?
artidoro
reviewed
Jan 3, 2019
| @@ -13,16 +13,16 @@ namespace Microsoft.ML.Data | |||
| /// A convenience class for concatenating several schemas together. | |||
| /// This would be necessary when combining IDataViews through any type of combining operation, for example, zip. | |||
| /// </summary> | |||
| internal sealed class CompositeSchema : ISchema | |||
| internal sealed class ZipBinding | |||
There was a problem hiding this comment.
ZipBinding [](start = 26, length = 10)
Why is it called ZipBinding?
There was a problem hiding this comment.
It's not a Schema. It takes several input schemas and produce an output schema.
artidoro
reviewed
Jan 3, 2019
| @@ -13,16 +13,16 @@ namespace Microsoft.ML.Data | |||
| /// A convenience class for concatenating several schemas together. | |||
| /// This would be necessary when combining IDataViews through any type of combining operation, for example, zip. | |||
| /// </summary> | |||
There was a problem hiding this comment.
Maybe we need to change this comment, as it seems to be suggesting that zip is not the only use?
wschin
force-pushed
the
compositeschema-revise
branch
from
5d36b83 to
f595681
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue removing ISchema one-by-one. It's a part of #1501.