Remove NoMetadataSchema and make its relatives not ISchema #2080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfilipi
reviewed
Jan 9, 2019
| @@ -810,27 +810,48 @@ public DataViewSlicer(IHost host, IDataView input, int[] toSlice) | |||
| { | |||
| var splitter = _splitters[c] = Splitter.Create(_input, toSlice[c]); | |||
| _host.Assert(splitter.ColumnCount >= 1); | |||
| // One splitter can produce multiple columns because it split a input column into multiple output columns. | |||
There was a problem hiding this comment.
split a [](start = 76, length = 7)
nit: splits an
There was a problem hiding this comment.
sfilipi
reviewed
Jan 9, 2019
| var selectedColumn = _view.Schema[col]; | ||
| var schemaBuilder = new SchemaBuilder(); | ||
| for (int c = 0; c < _lims.Length; ++c) | ||
| schemaBuilder.AddColumn(selectedColumn.Name, _types[c]); |
There was a problem hiding this comment.
schemaBuilder.AddColumn(selectedColumn.Name, _types[c]); [](start = 27, length = 57)
double-checking that omitting metadata is deliberate.
There was a problem hiding this comment.
It is reasonable because splitting a vector-valued column breaks most metadata. It's why previously Splitter was a NoMetadataSchema.
In reply to: 246463230 [](ancestors = 246463230)
sfilipi
approved these changes
Jan 10, 2019
wschin
force-pushed
the
remove-an-ischema-family
branch
from
4000d1e to
adc2db2
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. This PR belongs to #1501.