Make ScoreMapperSchema and its relatives not ISchema #2107
Conversation
wschin
requested review from
eerhardt,
TomFinley,
Ivanidzo4ka and
najeeb-kazmi
| /// </summary> | ||
| public abstract class ScoreMapperSchemaBase : ISchema | ||
| [BestFriend] | ||
| internal static class ScoreSchemaFactory |
There was a problem hiding this comment.
Can we rename this file to match the class that is inside of it? ScoreSchemaFactory.cs
| } | ||
| } | ||
| // Schema of Score column. We are going to extend it by adding a Probability column. | ||
| var partialSchema = Create(NumberType.Float, MetadataUtils.Const.ScoreColumnKind.BinaryClassification, scoreColumnName); |
There was a problem hiding this comment.
(minor) It feels a bit heavy-weight to create a whole schema object just to get 1 column out of it.
There was a problem hiding this comment.
This saves lines of creating metadata for that column (~6 lines). :)
1. Remove ScoreMapperSchema and its relatives entirely 2. Create static functions to generate commonly-used Schema
wschin
force-pushed
the
make-score-mapper-schema-not-ischema
branch
from
813a0ff to
acf718f
Compare
| } | ||
| } | ||
|
|
||
| public sealed class SequencePredictorSchema : ScoreMapperSchemaBase |
There was a problem hiding this comment.
SequencePredictorSchema [](start = 24, length = 23)
We use this schema in internal schema, if you remove it, that would force someone else to write code in internal repo.
There was a problem hiding this comment.
@Ivanidzo4ka - that's the intention. ISchema is going away, so any code (internal or public) that depends on it will need to be updated. #Resolved
There was a problem hiding this comment.
@[email protected], after running 5 out of 7 sequence-related TLC tests, I still don't find a place where this object is actually used. In TLC code base, SequencePredictorSchema's constructor always bypasses the part which distinguish it from ScoreMapperSchemaBase because keyNames.Length is always 0. Therefore, we don't even know if this class was created correctly. Is a replacement to this class required?
[Update] I am adding a test based on what I can find in TLC and creating a factory maethod to sequence predictor.
In reply to: 246872132 [](ancestors = 246872132)
There was a problem hiding this comment.
ghost
locked as resolved and limited conversation to collaborators
This PR wants to join the march of #1501.