Skip to content

Added <Link> to CommonPackage.props for native DLLs #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2019

Conversation

najeeb-kazmi
Copy link
Member

Fixes #1851

I built the nugets locally and tested in a new solution to verify that the issue described in #1851 was resolved.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. But please fix up the whitespace.

Copy link
Member

@singlis singlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@najeeb-kazmi najeeb-kazmi merged commit 447e94e into dotnet:master Jan 11, 2019
@najeeb-kazmi najeeb-kazmi deleted the 1851 branch January 30, 2020 01:14
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native assemblies from NuGet aren't copied correctly for packages.config
3 participants