Remove ISchema in BinaryLoader #2139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
reviewed
Jan 14, 2019
| @@ -472,6 +472,11 @@ private abstract class MetadataTableOfContentsEntry | |||
|
|
|||
| protected readonly BinaryLoader Parent; | |||
|
|
|||
| /// <summary> | |||
| /// Retuen the getter to the stored entry value as <see cref="Delegate"/>. | |||
There was a problem hiding this comment.
Thank you. Fixed. #Resolved
wschin
force-pushed
the
no-binary-loader-ischema
branch
from
558d3cd to
49fa1f6
Compare
TomFinley
reviewed
Jan 14, 2019
| @@ -757,7 +730,7 @@ public void GetMetadata<TValue>(string kind, int col, ref TValue value) | |||
| /// </summary> | |||
| private const ulong ReaderFirstVersion = 0x0001000100010002; | |||
|
|
|||
| public Schema Schema { get { return _schema; } } | |||
| public Schema Schema { get { return _outputSchema; } } | |||
There was a problem hiding this comment.
public Schema Schema { get { return _outputSchema; } } [](start = 8, length = 54)
Cool thanks @wshin. If perchance you happen to need to do some more commits, no harm C# 6/7-ifying these properties. But no hard feelings if you don't of course, just if quite convenient. #Resolved
There was a problem hiding this comment.
TomFinley
approved these changes
Jan 14, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Parade of #1501 continues today.