Remove ISchema in TextLoader.cs and TextLoaderCursor.cs

[wschin]

As title. This might be the tail of #1501.

[TomFinley]

name type [](start = 64, length = 9)

Not a big deal perhaps since this is not a public comment, but what is a "name type"? #Resolved

[wschin]

name type is changed to name and type. Thanks.

---

In reply to: 247681984 [](ancestors = 247681984)

[TomFinley]

either header+ not set in args [](start = 26, length = 30)

I might prefer something like an actual reference using a <see tag to the Arguments.HasHeader field, given that we're now making this an XML comment, and we're working to de-emphasize the role of the command line in our code documentation. Not a big deal though. #Resolved

[wschin]

Now we have

            /// <summary>
            /// Empty if <see cref="ArgumentsCore.HasHeader"/> is false, no header presents, or upon load
            /// there was no header stored in the model.
            /// </summary>

---

In reply to: 247682367 [](ancestors = 247682367)

[TomFinley]

        public readonly Segment[] Segments;

The reason why we had things like Name nad Kind stored in this array was to support the implementation of ISchema, which no longer exists. Yet, we are still storing it as part of this, and creating the parallel structure in the Schema itself. Should we get rid of the information that is redundant and duplicated from the schema itself, retaining all the stuff we actually still need like this segment stuff, but otherwise relying on the schema? Or is that perhaps too large of a change?

---

Refers to: src/Microsoft.ML.Data/DataLoadSave/Text/TextLoader.cs:449 in f690af1. [](commit_id = f690af1, deletion_comment = False)

[TomFinley]

Looks fine @wschin , my major comment is just wondering if we can make the TextLoader.ColInfo more efficient since much of its information is now redundant, with your introduction of Schema instead of ISchema. Still a definite improvement, and what I am suggesting would not be user facing, just an efficiency/code hygiene thing.

[wschin]

@TomFinley, Thank you! Let me open an issue for cleaning TextLoader.ColInfo because some utility functions rely on that type so removing may incur a mid-scale re-factorization.

[sfilipi]

false [](start = 66, length = 5)

#Resolved

[sfilipi]