Skip to content

Rename FeatureContributionClaculator => FeatureContributionCalculator #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2019
Merged

Rename FeatureContributionClaculator => FeatureContributionCalculator #2160

merged 1 commit into from
Jan 16, 2019

Conversation

endintiers
Copy link
Contributor

Addresses Issue #2150

A dirty job but someone has to do it :-). As a newbie I thought this might be the best way to start...

No new tests but existing tests run OK.

@dnfclas
Copy link

dnfclas commented Jan 16, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

Ivanidzo4ka
Ivanidzo4ka approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4ka
Copy link
Contributor

Thank you so much for your dirty job @endintiers!

artidoro
artidoro approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@artidoro artidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@artidoro artidoro merged commit 0b72301 into dotnet:master Jan 16, 2019
@rogancarr
Copy link
Contributor

Thanks!!! :)

@joelving joelving mentioned this pull request Jan 25, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ivanidzo4ka Ivanidzo4ka Ivanidzo4ka approved these changes

@artidoro artidoro artidoro approved these changes

@rogancarr rogancarr Awaiting requested review from rogancarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@endintiers @dnfclas @Ivanidzo4ka @rogancarr @artidoro