Skip to content

Add reference to any form of API? #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Conversation

kilick
Copy link
Contributor

@kilick kilick commented Jan 23, 2019

Is this the best API reference for this?

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

Is this the best API reference for this?
@sfilipi sfilipi requested review from eerhardt, shauheen and glebuk and removed request for eerhardt January 27, 2019 07:07
Co-Authored-By: kilick <[email protected]>
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3bc01c4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2209   +/-   ##
=========================================
  Coverage          ?   71.17%           
=========================================
  Files             ?      788           
  Lines             ?   140589           
  Branches          ?    16083           
=========================================
  Hits              ?   100062           
  Misses            ?    36082           
  Partials          ?     4445
Flag Coverage Δ
#Debug 71.17% <ø> (?)
#production 71.17% <ø> (?)
#test 71.17% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc01c4...8ed9e57. Read the comment docs.

@justinormont justinormont merged commit aedc4f7 into dotnet:master Jan 29, 2019
@kilick kilick deleted the patch-1 branch January 29, 2019 12:35
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants