Skip to content

Remove ZLib APIs #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Remove ZLib APIs #2262

merged 1 commit into from
Jan 29, 2019

Conversation

eerhardt
Copy link
Member

This code is not being called by ML.NET, and it was not intended to be public API. Removing.

Fix #2249

This code is not being called by ML.NET, and it was not intended to be public API. Removing.

Fix dotnet#2249
@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #2262 into master will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2262      +/-   ##
==========================================
+ Coverage   69.86%   69.99%   +0.12%     
==========================================
  Files         786      783       -3     
  Lines      144082   143817     -265     
  Branches    16622    16592      -30     
==========================================
+ Hits       100665   100666       +1     
+ Misses      39544    38604     -940     
- Partials     3873     4547     +674
Flag Coverage Δ
#Debug 69.99% <ø> (+0.12%) ⬆️
#production 66.28% <ø> (+0.15%) ⬆️
#test 84.99% <ø> (ø) ⬆️

Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @eerhardt !!

@eerhardt eerhardt requested a review from sfilipi January 28, 2019 23:18
Copy link
Member

@sfilipi sfilipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eerhardt eerhardt merged commit 4627647 into dotnet:master Jan 29, 2019
@eerhardt eerhardt deleted the RemoveZLib branch January 29, 2019 00:28
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants