Skip to content

Remove slash from PackagePath #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2019

Conversation

Ivanidzo4ka
Copy link
Contributor

fixes #2255

@eerhardt
Copy link
Member

Do these need to be fixed as well?

<Content Include="$(PackageAssetsPath)$(PackageIdFolderName)\LICENSE.txt" Pack="true" PackagePath=".\" />

<Content Include="$(SourceDir)Native\MatrixFactorizationNative\libmf\COPYRIGHT" Pack="true" PackagePath=".\" />

<Content Include="$(PackagesDir)\mlnetmkldeps\$(MlNetMklDepsPackageVersion)\LICENSE.txt" Pack="true" PackagePath=".\NOTICE.txt" />

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #2285 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2285      +/-   ##
==========================================
+ Coverage   69.89%   69.91%   +0.01%     
==========================================
  Files         786      786              
  Lines      144268   144268              
  Branches    16635    16635              
==========================================
+ Hits       100842   100866      +24     
+ Misses      38876    38849      -27     
- Partials     4550     4553       +3
Flag Coverage Δ
#Debug 69.91% <ø> (+0.01%) ⬆️
#production 66.18% <ø> (+0.01%) ⬆️
#test 85.01% <ø> (+0.01%) ⬆️

@Ivanidzo4ka Ivanidzo4ka merged commit b21c9b3 into dotnet:master Jan 29, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linqpad fails to load ml.net because of wrong package definition
3 participants