Fix TextLoader version number for KeyType backward compatibility and added new test #2295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2295 +/- ##
==========================================
+ Coverage 69.89% 70.04% +0.14%
==========================================
Files 786 784 -2
Lines 144268 144060 -208
Branches 16635 16607 -28
==========================================
+ Hits 100842 100910 +68
+ Misses 38876 38600 -276
Partials 4550 4550
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2294.
I fixed the version number that's used to recognize and load the old
TextLoaderformat.I also add a test to check that the code for
TextLoaderis actually backward compatible. I created a pipeline that contains aTextLoaderthat loads aKeyTypeusing a version of the code prior the changes toKeyTypeand loaded it with the new code checking for the expected behavior.