Skip to content

Fix fake schema's creation and add a test #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2019
Merged

Fix fake schema's creation and add a test #2331

merged 2 commits into from
Jan 30, 2019

Conversation

wschin
Copy link
Member

@wschin wschin commented Jan 30, 2019

Fix #2322 and add a test.

@wschin wschin added the bug Something isn't working label Jan 30, 2019
@wschin wschin self-assigned this Jan 30, 2019
@wschin wschin requested review from artidoro and sfilipi January 30, 2019 19:38
@wschin wschin changed the title Fix fkae schema's creation and add a test Fix fake schema's creation and add a test Jan 30, 2019
artidoro
artidoro approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@artidoro artidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4ka
Copy link
Contributor

using System;

header please

Refers to: test/Microsoft.ML.Tests/FakeSchemaTest.cs:1 in cf213f7. [](commit_id = cf213f7, deletion_comment = False)

Ivanidzo4ka
Ivanidzo4ka approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wschin wschin merged commit 6783a61 into dotnet:master Jan 30, 2019
@wschin wschin deleted the fix-fake-schema branch January 30, 2019 21:10
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ivanidzo4ka Ivanidzo4ka Ivanidzo4ka approved these changes

@artidoro artidoro artidoro approved these changes

@sfilipi sfilipi Awaiting requested review from sfilipi

Assignees

@wschin wschin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wschin @Ivanidzo4ka @artidoro