introduce IUnsupervisedLearningWithWeights #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomFinley
approved these changes
May 24, 2018
There was a problem hiding this comment.
Thanks @Ivanidzo4ka ! You think a test to check this, sort of like how @yaeldekel added a use-case for weights, might be appropriate?
…weight column. also extract real weight value from cursor.
| @@ -1918,7 +1918,7 @@ public void EntryPointTrainTestMacroNoTransformInput() | |||
| [Fact] | |||
| public void EntryPointKMeans() | |||
| { | |||
| TestEntryPointRoutine("Train-Tiny-28x28.txt", "Trainers.KMeansPlusPlusClusterer"); | |||
| TestEntryPointRoutine("Train-Tiny-28x28.txt", "Trainers.KMeansPlusPlusClusterer", "col=Weight:R4:0 col=Features:R4:1-784", ",'InitAlgorithm':'KMeansPlusPlus'"); | |||
There was a problem hiding this comment.
Is there a test without a Weight column?
There was a problem hiding this comment.
In internal repo
There was a problem hiding this comment.
Should we move the test to the public repo, or keep it in the internal?
There was a problem hiding this comment.
We moving/enabling baseline tests in separate PRs.
eerhardt
pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
* introduce IUnsupervisedLearningWithWeights * add test to check KMeans don't need label and can handle presence of weight column. also extract real weight value from cursor.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #225