Fix loading type problem for netfx #2409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2409 +/- ##
=========================================
Coverage ? 71.24%
=========================================
Files ? 785
Lines ? 140893
Branches ? 16103
=========================================
Hits ? 100383
Misses ? 36044
Partials ? 4466
|
eerhardt
reviewed
Feb 5, 2019
eerhardt
approved these changes
Feb 5, 2019
|
@Ivanidzo4ka @sfilipi @justinormont can you please review this PR ? |
justinormont
reviewed
Feb 5, 2019
| @@ -135,7 +135,8 @@ void TestOldSavingAndLoading() | |||
| [ConditionalFact(typeof(Environment), nameof(Environment.Is64BitProcess))] // x86 output differs from Baseline | |||
| void TestCommandLine() | |||
| { | |||
| var env = new MLContext(); | |||
| // typeof helps to load the TensorFlowTransformer type. | |||
| Type type = typeof(TensorFlowTransformer); | |||
There was a problem hiding this comment.
Any idea why typeof helps?
There was a problem hiding this comment.
So when we create an instance of a type in Maml, we check if the type\assembly is present in the loaded modules.
Typeof helps to load the assembly involving this type.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2104
A couple of types doesn't get loaded properly by Maml commands on netfx. So we have to register them manually.
We are doing a similar things for maml commands in our benchmarks.
These tests fail on netfx and are being enabled in #2402