-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Moved TensorFlow samples to its own directory in Samples project. #2429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2429 +/- ##
==========================================
- Coverage 71.26% 71.22% -0.04%
==========================================
Files 785 785
Lines 140946 141034 +88
Branches 16108 16112 +4
==========================================
+ Hits 100440 100450 +10
- Misses 36039 36116 +77
- Partials 4467 4468 +1
|
docs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/ImageClassification.cs
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/TextClassification.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't notice it in the first pass, but I think you are trying to add yet another example of how to use the ScoreTensorFlowModel xtension, for text this time? If that is the case, that is unecessary, because the API reference samples just need one example to illustrate how to use the API. Samples for the Various scenarios, and things you can do with the components go under the machienlearning-samples repo. Now, if you can turn around the sample, in a way that illustrates one of the other ScoreTensorFlowModel extensions, that would be useful. #Resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
I feel one sample is not enough to show the various different models that can be used with TensorFlowTransform in ML.NET. I am updating the sample to use the different extension of In reply to: 461202841 [](ancestors = 461202841) |
@@ -43,7 +43,7 @@ internal TensorFlowModelInfo(IHostEnvironment env, TFSession session, string mod | |||
/// <summary> | |||
/// Get <see cref="Schema"/> for complete model. Every node in the TensorFlow model will be included in the <see cref="Schema"/> object. | |||
/// </summary> | |||
internal Schema GetModelSchema() | |||
public Schema GetModelSchema() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public [](start = 8, length = 6)
This need to be public. Its helpful to get the schema without loading model again. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR addresses following issues
TensorFlow
folder in samples project.@sfilipi, @shmoradims and @rogancarr, let me know if this move can be a problem for any documentation referencing it.