Internalize IDataTransform #2509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artidoro
reviewed
Feb 12, 2019
| @@ -244,7 +247,8 @@ public override bool IsColumnActive(int col) | |||
| /// on multiple input columns. | |||
| /// This class provides the implementation of ISchema and IRowCursor. | |||
| /// </summary> | |||
| public abstract class OneToOneTransformBase : RowToRowMapperTransformBase, ITransposeDataView, ITransformCanSavePfa, | |||
| [BestFriend] | |||
| internal abstract class OneToOneTransformBase : RowToRowMapperTransformBase, ITransposeDataView, ITransformCanSavePfa, | |||
| ITransformCanSaveOnnx | |||
There was a problem hiding this comment.
There are a few [BestFriend] in this class, if you are doing another iteration, maybe we could make those public and remove the attribute. Not a requirement though.
Codecov Report
@@ Coverage Diff @@
## master #2509 +/- ##
=======================================
Coverage 71.24% 71.24%
=======================================
Files 798 798
Lines 141231 141231
Branches 16112 16112
=======================================
Hits 100623 100623
Misses 36142 36142
Partials 4466 4466
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide the unhideable, bestfriend the unfrienable!
fixes #1995