Fix an initial-value problem caused by unseen row/column #2525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have a test? |
|
As you wish. :) In reply to: 463012943 [](ancestors = 463012943) |
Codecov Report
@@ Coverage Diff @@
## master #2525 +/- ##
==========================================
+ Coverage 71.25% 71.26% +0.01%
==========================================
Files 798 797 -1
Lines 141252 141328 +76
Branches 16112 16118 +6
==========================================
+ Hits 100643 100720 +77
- Misses 36145 36146 +1
+ Partials 4464 4462 -2
|
Ivanidzo4ka
reviewed
Feb 13, 2019
test/Microsoft.ML.Tests/TrainerEstimators/MatrixFactorizationTests.cs
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update LIBMF to have this fix. The problem is that when the largest row index in the training set doesn't match the number of rows in the specified matrix shape, rows' starting addresses may look like
[ptr_to_first_element_in_row_1, ptr_to_first_element_in_row_8, ptr_to_the_end_of_element_array, nullptr, nullptr]but the correct value should be[ptr_to_first_element_in_row_1, ptr_to_first_element_in_row_8, ptr_to_the_end_of_element_array, ptr_to_the_end_of_element_array, ptr_to_the_end_of_element_array].Fixes #2488