Reorder MatrixFactorizationTrainer parameters #2561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschin
reviewed
Feb 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
==========================================
- Coverage 71.57% 71.57% -0.01%
==========================================
Files 800 800
Lines 141789 141789
Branches 16107 16107
==========================================
- Hits 101488 101486 -2
- Misses 35851 35853 +2
Partials 4450 4450
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1826
Changed order of parameters to make labelColumn the first parameter. Since the following two parameters after reordering were required, I had to remove the default label name from the labelColumn param.