Skip to content

Lockdown Microsoft.ML.Data Dataview folder. #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2019
Merged

Lockdown Microsoft.ML.Data Dataview folder. #2608

merged 2 commits into from
Feb 19, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented Feb 19, 2019

fixes #2606

@codemzs codemzs self-assigned this Feb 19, 2019
@codemzs codemzs added the API Issues pertaining the friendly API label Feb 19, 2019
@codemzs codemzs added this to the 0219 milestone Feb 19, 2019
@codecov
Copy link

codecov bot commented Feb 19, 2019 •
edited
Loading

Codecov Report

Merging #2608 into master will decrease coverage by <.01%.
The diff coverage is 65%.

@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
- Coverage   71.53%   71.52%   -0.01%     
==========================================
  Files         800      800              
  Lines      141866   141861       -5     
  Branches    16122    16121       -1     
==========================================
- Hits       101478   101472       -6     
- Misses      35937    35938       +1     
  Partials     4451     4451
Flag Coverage Δ
#Debug 71.52% <65%> (-0.01%) ⬇️
#production 67.8% <30%> (-0.01%) ⬇️
#test 85.77% <100%> (-0.01%) ⬇️

TomFinley
TomFinley approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @codemzs for locking down more of these infrastructure dataview implementations, and other cleanup!

Ivanidzo4ka
Ivanidzo4ka approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit a56caee into dotnet:master Feb 19, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ivanidzo4ka Ivanidzo4ka Ivanidzo4ka approved these changes

@TomFinley TomFinley TomFinley approved these changes

Assignees

@codemzs codemzs

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
0219
Development

Successfully merging this pull request may close these issues.

Internalization of Microsoft.ML.Data Dataview folder
3 participants
@codemzs @Ivanidzo4ka @TomFinley