Renaming ColumnInfo to ColumnOptions #2709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanidzo4ka
reviewed
Feb 25, 2019
| @@ -94,14 +94,14 @@ internal RowInfo(int n) | |||
| } | |||
| } | |||
|
|
|||
| public sealed class ColumnInfo | |||
| public sealed class ColumnOptions | |||
There was a problem hiding this comment.
ColumnOptions [](start = 28, length = 13)
Why? #Resolved
There was a problem hiding this comment.
There was a problem hiding this comment.
Will revert that.
#Resolved
Codecov Report
@@ Coverage Diff @@
## master #2709 +/- ##
==========================================
- Coverage 71.67% 71.66% -0.02%
==========================================
Files 808 808
Lines 142364 142364
Branches 16121 16121
==========================================
- Hits 102043 102025 -18
- Misses 35879 35901 +22
+ Partials 4442 4438 -4
|
sfilipi
reviewed
Feb 25, 2019
| @@ -9,24 +9,24 @@ | |||
|
|
|||
| namespace Microsoft.ML | |||
| { | |||
| public sealed class SimpleColumnInfo | |||
| public sealed class ColumnOptions | |||
There was a problem hiding this comment.
ColumnOptions [](start = 24, length = 13)
SimpleColumnOptions, or complete renamind was intentional.
There was a problem hiding this comment.
It was intentional, why do you think that SimpleColumnOptions is better?
I thought that for consistency it was better like this.
artidoro
commented
Feb 25, 2019
| new NormalizingEstimator.MinMaxColumn("MinMaxNormalized", "Features", fixZero: true), | ||
| new NormalizingEstimator.MeanVarColumn("MeanVarNormalized", "Features", fixZero: true), | ||
| new NormalizingEstimator.BinningColumn("BinNormalized", "Features", numBins: 256)); | ||
| new NormalizingEstimator.MinMaxColumnOptions("MinMaxNormalized", "Features", fixZero: true), |
There was a problem hiding this comment.
Update the cookbook #Resolved
artidoro
force-pushed
the
columnoption
branch
from
401b86b to
7124b4a
Compare
artidoro
force-pushed
the
columnoption
branch
from
7124b4a to
0ed9ec2
Compare
This was referenced Mar 6, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2554.
As discussed in the issue, we decided to rename
ColumnInfotoColumnOptions.I used Visual Studio to find and replace instances of
ColumnInfo. I did an operation of find and replace for each different casing. I also went over the changes to double check.