Skip to content

Internalize Microsoft.ML.Internal.CpuMath.GeneralUtils. #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2019
Merged

Internalize Microsoft.ML.Internal.CpuMath.GeneralUtils. #2741

merged 1 commit into from
Feb 26, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented Feb 26, 2019

fixes #2737

@codemzs codemzs requested review from eerhardt and sfilipi February 26, 2019 18:27
eerhardt
eerhardt approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@codecov
Copy link

codecov bot commented Feb 26, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d6a4b1d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2741   +/-   ##
=========================================
  Coverage          ?   71.66%           
=========================================
  Files             ?      808           
  Lines             ?   142277           
  Branches          ?    16140           
=========================================
  Hits              ?   101969           
  Misses            ?    35870           
  Partials          ?     4438
Flag Coverage Δ
#Debug 71.66% <ø> (?)
#production 67.91% <ø> (?)
#test 85.86% <ø> (?)
Impacted Files Coverage Δ
src/Microsoft.ML.CpuMath/CpuAligenedMathUtils.cs 73.23% <ø> (ø)

@codemzs codemzs merged commit 559c292 into dotnet:master Feb 26, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@sfilipi sfilipi sfilipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internalize Microsoft.ML.Internal.CpuMath.GeneralUtils
3 participants
@codemzs @eerhardt @sfilipi